On Wed, Mar 03, 2004 at 07:26:40AM -0500, Jeff Trawick wrote:
> > + if (getrlimit(RLIMIT_CORE, &lim) == 0 && lim.rlim_cur == 0) {
> > + lim.rlim_cur = lim.rlim_max;
> > + if (setrlimit(RLIMIT_CORE, &lim) == 0) {
>
> In your patch, if the hard limit for core files is zero, there won't be a
> message, will there?
No, but not by intent particularly.
> I definitely prefer always reporting a missing CoreDumpDirectory if the
> server started as root.
>
> I definitely prefer always reporting when the core limit is zero, root or
> not.
I don't think adding any warnings unless CoreDumpDirectory is used is
sensible, since it would add a warning for the default config on any
system which has the limit set to zero by default: something which
{some,many,most} people don't care about, I'd argue.
joe
