Re: [PATCH] mod_alias.c - add filename to log warning

[Dirk-Willem van Gulik]

On Mar 9, 2004, at 2:25 AM, Guenter Knauf wrote:

--- mod_alias.c.orig    Tue Feb 10 00:16:10 2004
+++ mod_alias.c         Mon Mar 08 22:06:20 2004
@@ -137,9 +137,10 @@
             if (  (!p->regexp &&  alias_matches(f, p->fake) > 0)
                 || (p->regexp && !ap_regexec(p->regexp, f, 0, NULL, 
0))) {
                 ap_log_error(APLOG_MARK, APLOG_WARNING, 0, 
cmd->server,
-                             "The %s directive at line %d will 
probably never "
+                             "The %s directive in %s at line %d will 
probably never "
                              "match because it overlaps an earlier 
%sAlias%s.",
-                             cmd->cmd->name, cmd->directive->line_num,
+                             cmd->cmd->name, cmd->directive->filename,
+                             cmd->directive->line_num,
                              p->handler ? "Script" : "",
                              p->regexp ? "Match" : "");

+1 - this has bitten me more than once.

Dw