Re: cvs commit: httpd-2.0/support ab.c

[Jeff Trawick]

[EMAIL PROTECTED] wrote:
clar        2004/03/16 08:57:02

  Modified:    support  ab.c
  Log:
  added check on apr_pollset_create() return value to exit ab it case it fails.
  On NetWare using a concurrency higher than 64 is segfaulting because of FD_SETSIZE 
as a value of 64.
   Index: ab.c
  -    apr_pollset_create(&readbits, concurrency, cntxt, 0);
  +
  +    if ((status = apr_pollset_create(&readbits, concurrency, cntxt, 0)) != 
APR_SUCCESS) {
  +        fprintf(stderr, "\napr_pollset_create failed: %d\n", status);
  +        exit(status);
  +    }
your change is obviously a vast improvement, but what about

   if ("it failed") {
       apr_err("apr_pollset_create failed", status);
   }