Attached: a one-line bugfix to my recent patch.  The inflate output
filter needs to unset the Content-Encoding header when it unsets
the content encoding.

Also a question: When I create a bucket brigade in a module, I always
explicitly apr_brigade_destroy() it.  None of the filters in mod_deflate
destroy their brigades.  A look at apr_brigade.c shows that it's not
in fact necessary, but maybe a note to that effect would be in order?

-- 
Nick Kew

Nick's manifesto: http://www.htmlhelp.com/~nick/
--- mod_deflate.c       2004-04-18 13:06:13.000000000 +0100
+++ mod_deflate.c.old   2004-04-18 13:07:44.000000000 +0100
@@ -895,6 +895,7 @@
             ap_remove_output_filter(f);
             return ap_pass_brigade(f->next, bb);
         }
+       apr_table_unset(r->headers_out, "Content-Encoding") ;
 
         f->ctx = ctx = apr_pcalloc(f->r->pool, sizeof(*ctx));
         ctx->proc_bb = apr_brigade_create(r->pool, f->c->bucket_alloc);

Reply via email to