Re: cvs commit: httpd-2.0/server log.c

[Jean-Jacques Clar]

I think there is a little typo with the submitted patch:   Index: server/log.c =================================================================== RCS file: /home/cvs/httpd-2.0/server/log.c,v retrieving revision 1.145 diff -u -r1.145 log.c --- server/log.c 27 May 2004 23:35:41 -0000 1.145 +++ server/log.c 8 Jun 2004 20:05:57 -0000 @@ -197,7 +197,7 @@      apr_proc_t *procnew;        if (((rc = apr_procattr_create(&procattr, p)) == APR_SUCCESS) -        && ((rc == apr_procattr_cmdtype_set(procattr, +        && ((rc = apr_procattr_cmdtype_set(procattr,                                              APR_PROGRAM_ENV)) == APR_SUCCESS)          && ((rc = apr_procattr_io_set(procattr,                                        APR_FULL_BLOCK, >>> [EMAIL PROTECTED] 5/27/2004 5:35:41 PM >>> trawick     2004/05/27 16:35:41   Modified:    .        CHANGES                server   log.c   Log:   Pass environment variables through to piped loggers, resolving   a regression since 1.3.     Submitted by:      Ken Coar, Jeff Trawick     Revision  Changes    Path   1.1497    +3 -0      httpd-2.0/CHANGES     Index: CHANGES   ===================================================================   RCS file: /home/cvs/httpd-2.0/CHANGES,v   retrieving revision 1.1496   retrieving revision 1.1497   diff -u -r1.1496 -r1.1497   --- CHANGES    26 May 2004 23:33:35 -0000    1.1496   +++ CHANGES    27 May 2004 23:35:40 -0000    1.1497   @@ -2,6 +2,9 @@         [Remove entries to the current 2.0 section below, when backported]      +  *) Pass environment variables through to piped loggers, resolving   +     a regression since 1.3.  [Ken Coar, Jeff Trawick]   +      *) Enable the option to support anonymous shared memory in mod_ldap.         This makes the cache work on Linux again. [Graham Leggett]            1.145     +4 -0      httpd-2.0/server/log.c     Index: log.c   ===================================================================   RCS file: /home/cvs/httpd-2.0/server/log.c,v   retrieving revision 1.144   retrieving revision 1.145   diff -u -r1.144 -r1.145   --- log.c    6 May 2004 10:18:07 -0000    1.144   +++ log.c    27 May 2004 23:35:41 -0000    1.145   @@ -197,6 +197,8 @@        apr_proc_t *procnew;           if (((rc = apr_procattr_create(&procattr, p)) == APR_SUCCESS)   +        && ((rc == apr_procattr_cmdtype_set(procattr,   +                                            APR_PROGRAM_ENV)) == APR_SUCCESS)            && ((rc = apr_procattr_io_set(procattr,                                          APR_FULL_BLOCK,                                          APR_NO_PIPE,   @@ -722,6 +724,8 @@        apr_status_t status;           if (((status = apr_procattr_create(&procattr, pl->p)) != APR_SUCCESS) ||   +        ((status = apr_procattr_cmdtype_set(procattr,   +                                            APR_PROGRAM_ENV)) != APR_SUCCESS) ||            ((status = apr_procattr_child_in_set(procattr,                                                 ap_piped_log_read_fd(pl),                                                 ap_piped_log_write_fd(pl)))