I should amend my vote a -.5. The patch should work as you've coded it but opening a file for use with apr_sendfile causes the file to be opened for overlapped i/o on Windows. I expect some of the codepaths will not correctly handle this (Jeff and I fixed one such case when a file was opened for sendfile but mod_ssl prevented apr_sendfile from actually being used). Probably more bugs but they need to be found and fixed and I have no idea if there are other similar issues on platforms other than windows.
Hmm. Does opening it for overlapped I/O cause a performance hit if we don't use sendfile later on? I sort of dislike the fact that we even have to open it with the SENDFILE flag at all. But, I think asking non-core modules to read the core_dir_config just for this is asking too much. *shrug* -- justin
