On Wed, Aug 11, 2004 at 03:51:13PM -0700, Justin Erenkrantz wrote:
Please back up a bit.
Why do you think the modes should be combined? -- justin
More details: ------------- Why bitflags, you ask?
AP_MODE_MIME_FOLDING = 16
yuck.
getline would be more efficient and easier to understand if we removed the folding code and created a separate function whose only job is to do folding, i.e., get single lines one at a time and combine them if appropriate. ap_get_mime_headers_core() works pretty much like that now, but it has optimizations and additional functions that won't work for a more general ap_get_folded_line() or whatever.
If the seldom used folding code is removed from the basic getline, there will be no need to test a folding flag/parameter in the usual non-folding case, and the instruction cache hit rate will improve.
As far as I know, only mod_proxy calls ap_getline today with the folding flag set. Third party modules could do the same, but if we changed this on a release boundary it shouldn't be too disruptive.
Greg
