Jeff Trawick wrote:
> See attached patch. Given a module with map-to-storage hook which
> leaves r->filename NULL, and config like the following, you get
> segfault on platforms that don't like strlen(NULL).
given that, I understand this part
- if (strcmp(r->filename, ofilename) == 0) {
+ if (ofilename != NULL && strcmp(r->filename, ofilename) == 0) {
but not the rest of the patch. why would you need/want to set r->filename
in this instance?
> odd to me that rewrite's translate_name hook, used for processing
> server config directives, can update r->filename permanently even when
> it declines
that's a common idiom for we mod_perl people :)
--Geoff
