On Wed, Sep 22, 2004 at 05:48:58PM +0200, Graham Leggett wrote: > This is already committed to v2.1.0-dev, and is awaiting votes: > > *) Fix a segfault in the LDAP cache purge. > modules/ldap/util_ldap_cache_mgr.c: 1.9 > +1: minfrin > 0: bnicholes - backporting modules/ldap/util_ldap_cache_mgr.c: > r1.7 below > should eliminate the need to backport the "else" condition > included > in this patch. > > It seems though that the comment about the else condition is mixing up > the patches - the above patch fixes util_ald_cache_purge(), while the > v1.7 patch fixes *util_ald_create_caches() and is unrelated to the patch > proposed.
I can't believe I have to write more than one e-mail about this -- please go and *read* what you committed: http://cvs.apache.org/viewcvs.cgi/httpd-2.0/modules/ldap/util_ldap_cache_mgr.c?annotate=1.9 215 util_url_node_t *util_ald_create_caches(util_ldap_state_t *st, const char *url) 216 { 217 jorton 1.7 util_url_node_t curl, *newcurl = NULL; ... 257 minfrin 1.9 else 258 newcurl = NULL;
