On 5 Oct 2004 21:04:20 -0000, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > ake 2004/10/05 14:04:20 > > Modified: server/mpm/winnt child.c > Log: > WIN64: SOCKET is not int on 64bit platforms > > Revision Changes Path > 1.39 +6 -6 httpd-2.0/server/mpm/winnt/child.c > > Index: child.c > - rc = select(listenmaxfd + 1, &main_fds, NULL, NULL, &tv); > + rc = select((int)(listenmaxfd + 1), &main_fds, NULL, NULL, &tv);
This change doesn't look right, and I suspect the support for the select() call has been doing unnecessary work all along. The change doesn't look right because an int can't hold the range of values of SOCKET, and listenmaxfd is SOCKET. <possible heresy> The first parameter to select() on Windows is actually ignored. We should zap the logic that does the Unix-style computation of listenmaxfd and just pass in INVALID_SOCKET or 0, and add a comment that the value is ignored. </possible heresy>
