Good point. I will get the patch committed
Brad
>>> "Jari Ahonen" <[EMAIL PROTECTED]> Thursday, November 04, 2004
7:39:01 AM >>>
Brad,
I think this patch should be applied to the current HEAD
util_ldap.c code. It prevents util_ldap_cache_getuserdn()
timestamping cache entries with bindpw.
- Jari
----- cut here ----- cut here -----
--- util_ldap.c.orig 2004-11-02 00:43:24.000000000 +0100
+++ util_ldap.c 2004-11-04 15:34:23.000000000 +0100
@@ -1096,7 +1096,12 @@
/* Nothing in cache, insert new entry */
util_ald_cache_insert(curl->search_cache,
&the_search_node);
}
- else {
+ /*
+ * Don't update lastbind on entries with bindpw because
+ * we haven't verified that password. It's OK to update
+ * the entry if there is no password in it.
+ */
+ else if (!search_nodep->bindpw) {
/* Cache entry is valid, update lastbind */
search_nodep->lastbind = the_search_node.lastbind;
}
----- cut here ----- cut here -----
>
