Small leak in mod_proxy?

[Ronald Park]

Hi All,

I was looking at mod_proxy and I'm not sure if this is a leak or not.
Well, it's surely not a leak since it's all pool-based, but it might
be made a little cleaner...

In proxy_http.c, ap_proxy_http_request() around line 627 it says:

        /* If this brigade contain EOS, either stop or remove it. */
        if (APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(bb))) {
            /* As a shortcut, if this brigade is simply an EOS bucket,
             * don't send anything down the filter chain.
             */
            if (APR_BUCKET_IS_EOS(APR_BRIGADE_FIRST(bb))) {
                break;
            }

This break makes it skip the apr_brigade_cleanup(bb) call at the end
of the do loop.  Shouldn't it cleanup this EOS brigade?

Thanks,
Ron
-- 
Ronald Park <[EMAIL PROTECTED]>