On Tue, 10 May 2005 23:36:57 -0000, [EMAIL PROTECTED] wrote:
[...]
>+const char * get_forensic_id(pool *p)
>+{
>+ static APACHE_TLS next_id = 0;
>+
>+ /* we make the assumption that we can't go through all the PIDs in
>+ under 1 second */
>+#ifdef MULTITHREAD
>+ return ap_psprintf(p, "%x:%lx:%x", getpid(), time(NULL), next_id++);
>+#else
>+ return ap_psprintf(p, "%x:%x:%lx:%x", getpid(), gettid(), time(NULL),
>next_id++);
>+#endif
Isn't the logic backwards here? I'd expect gettid() to be used only if
MULTITHREAD is defined.
This fails to build on OS/2 as there's no gettid(), even though MULTITHREAD
is not defined.
--
______________________________________________________________________________
| Brian Havard | "He is not the messiah! |
| [EMAIL PROTECTED] | He's a very naughty boy!" - Life of Brian |
------------------------------------------------------------------------------