On Mon, May 16, 2005 at 11:40:29AM +0100, Nick Kew wrote: > (2) mod_dbd is a utility for other modules, which it serves by > exporting three functions, best explained by a brief extract > from mod_dbd.h: ...
In terms of API, I'd much rather see *just* the optional function exports to avoid encouraging more module-load-ordering dependencies, and certainly must use the ap_dbd_* namespace not dbd_* if you weren't planning that rename already. Some basic review of mod_dbd.c itself: - should use APR apr_is* macros rather than is* directly - a few style nits here and there -- whitespace around inside if conditions ( ... ), switch etc - some unhealthy looking casts of functions to (void *) used as cleanups, child_init hook Regards, joe
