Ping? I really would like at least someone to say, yes, you aren't entirely crazy, and the extension to the configuration commands makes sense.
If I don't hear anything, I will just merge this into trunk tomorrow. -Paul Paul Querna wrote: > I have completed what I intend to do with the listen-protocol branch. I > would love some code review and criticism. > > Currently, the 'httpready' Accept Filter is always applied on FreeBSD. > This breaks protocols like NNTP where the server must send data first. > > Short: Existing Configurations should behave nearly the same. > > Long: > Extended the 'Listen' directive. Now optionally takes a protocol. If > none is specified, it uses 'http'. (backwards compat) > > # both of these are equivalent. > Listen 0.0.0.0:80 > Listen 0.0.0.0:80 http > # defaults to http > Listen 0.0.0.0:8080 > # Force these to HTTPS > Listen 0.0.0.0:443 https > Listen 0.0.0.0:8443 https > > Added the 'Protocol' directive. Sets the protocol for a server_rec. Can > inherit from a Listener. (eg, <VirtualHost 0.0.0.0:443> will inherit the > 'Protocol https' from the above Listen lines.) > > Added 'AcceptFilter' directive. This takes 2 args, the protocol and the > name of an Accept Filter. It does include defaults values: > FreeBSD: > AcceptFilter http httpready > AcceptFilter https dataready > Linux: > AcceptFilter http data > AcceptFilter https data > > On Linux, any value will enable TCP_DEFER_ACCEPT. > > Setting the name to 'none' will disable any accept filter for that > protocol. To fix the nntp test in the Perl-Test-Framework, just add: > Listen 119 nntp > # AcceptFilter nntp none > (The AcceptFilter directive is not required, since it defaults to none, > if the protocol doesn't have a default entry) > > Changed mod_ssl, to enable itself for any virtual hosts that are using > the 'https' protocol. This means 'SSLEngine on' is no longer required > to enable mod_ssl. We might not want merge this change, until a more > robust solution for registering protocols could be done. (I would like > to investigate doing that after trunk is branched.) > > To test the sandbox branch in your local working copy: > > svn merge -r 168457:HEAD > https://svn.apache.org/repos/asf/httpd/httpd/branches/listen-protocol . > > See the 'Vhosts, Listeners and Server_rec, Oh My!' thread for some bits > I do not like about the current structure of listeners. I didn't > attempt to solve these issue in this branch, since the possible changes > could be significant. > > Thanks, > > -Paul >
