On 4/25/05, Eric Covener <[EMAIL PROTECTED]> wrote:

> I've attached a patch that resolves the hostname in the URI and hands
> that off separately to ap_proxy_checkproxyblock().   Not quite sure of
> the pool usage though.

pool looks right to me...

> 
> In the event that we're forwarding to another proxy and no ProxyBlocks
> are in the config, the lookup of the URI hostname is avoided.

This part is in your somewhat-related 2.0 proxy fix as well:

+    if (conf->noproxies->nelts > 0)  {
+            err = apr_sockaddr_info_get(&uri_addr,

I think there should be a helper function ap_proxy_hasproxyblock() to
perform this check, so that the knowledge of that data structure is
restricted.

Any comments from the peanut gallery, particularly the proxy portion?

Reply via email to