On Monday 20 June 2005 06:44, Justin Erenkrantz wrote: > > Since the purpose of this directive is now available from mod_filter, > > does anyone object if I simply yank AddOutputFilterByType from 2.1? > > Why can't AddOutputFilterByType call mod_filter under the hood?
Good point. Of course it raises issues of filter order that I'd prefer to avoid. But that's at least less counterintuitive than the existing ordering with AddOutputFilterByType and [anything else]. > But, from the user's perspective, I think AddOutputFilterByType needs to > stay and I'm not convinced that mod_filter has a good enough directive > interface to make it intuitive. -- justin Hmmm. Is it better to have a UI that's openly a little more complex but works as documented, or one that appears simple but has lots of gotchas lurking in ambush? I guess that's an argument for mod_filter implementing AddOutputFilterByType. FWIW, it could also do SetOutputFilter, but AddOutputFilter may be more problematic, in that dispatching on filename/extension needs thought to avoid introducing another set of problems. But of course there's no pressing need to change those in the first place. -- Nick Kew
