William A. Rowe, Jr. wrote:
At 02:12 AM 6/20/2005, Paul Querna wrote:
William A. Rowe, Jr. wrote:
Also, possibly across platforms is a fault in ssl_engine_init,
where the host->protocol is still NULL, and we are trying to
strcmp it to 'https'. I spent part of my weekend trying to
grok what change has broken this, but strcmp to NULL is popping
a segfault. Not worthy of rejecting 2.1.5 on it's own, this is
still a minor irritation. FYI - mod_ssl was loaded without SSL
being defined, so no ssl host actually exists.
In all cases the protocol should be set, and never be null. Look at
ap_setup_listeners() in server/listen.c.
All linux cases as usual :-?
Ugh. FreeBSD actually, and all the *nix MPMs do this correctly :-P
ap_setup_listeners is only called in the parent. On mpm_winnt,
this happens in the open_logs hook of the parent.
I wish we had more 'rules' for MPMs. Right now its hit and miss. In
this case, I missed mpm_winnt...
get_listeners_from_parent in the mpm_winnt creates those per-child
listen records. Memory is not inherited between parent and child
so the patch to modify this broke win32.
Okay, I will look at breaking this out to a separate function, and then
calling it from the correct places in mpm_winnt.
This code seems a bit too convoluted for me to delve into right
now, and I'm not quite clear what problem the patch was ment to
solve in the first place (?)
The point is to inherit a Protocol in a Virtual Host from the Listening
Socket, if one wasn't explicitly set.
-Paul
