On Fri, Jul 22, 2005 at 12:11:56PM -0000, Martin Kraemer wrote:
> Author: martin
> Date: Fri Jul 22 05:11:55 2005
> New Revision: 220307
>
> URL: http://svn.apache.org/viewcvs?rev=220307&view=rev
> Log:
> Allow extraction of the values of SSL certificate extensions into
> environment variables, so that their value can be used by any
> module that is aware of environment variables, as in:
So what is the point in posting patches for review if you don't actually
wait for anyone to review them before committing?
> SetEnvIf OID("2.16.840.1.113730.1.13") "(.*) Generated (Certificate)" ca=$1
-1 on the naming since OID is completely entirely meaningless in this
context.
mod_setenvif.c:
> module AP_MODULE_DECLARE_DATA setenvif_module;
> +#if (MODULE_MAGIC_NUMBER_MAJOR > 20020903)
> +#include "mod_ssl.h"
unnecessary for trunk code to care about the MMN, it can always rely on
mod_ssl.h being available.
mod_ssl.h:
> +extern apr_array_header_t *ssl_extlist_by_oid(request_rec *r, const char
> *oidstr);
and don't export the function as well as the optional function.
