Colm MacCarthaigh wrote: > On Mon, Aug 08, 2005 at 12:41:56PM +0200, Andreas Steinmetz wrote: > >>Colm MacCarthaigh wrote: >> >>>On Mon, Aug 08, 2005 at 12:04:44AM +0100, Colm MacCarthaigh wrote:
[..cut..] >> >>Up to the apache maintainers to decide. One question, though. Why do you >> introduce directory_empty()? A blind call to apr_dir_remove() should be >>sufficient. It will fail if the directory is not empty and succeed if it is. > > > See my other comments about APR not claiming to ensure this behaviour. > What makes you think so? As previously stated this works on Unix systems and according to MS API doc it (RemoveDirectory) should behave in the same manner on Windows. I was not able to check the OS/2 code, as I found no documentation for DosDeleteDir, but I think this is an acceptable blind spot here. Regards Rüdiger
