Gregory (Grisha) Trubetskoy wrote:

Another thing that should probably go in before 3.2. The RedHat people patch mod_python with this patch in the source RPM (smart-ass comment included):

-------------

Stealing 1/4 of the available SysV semaphores is not polite behaviour.

--- mod_python-3.1.3/src/include/mod_python.h.maxlocks
+++ mod_python-3.1.3/src/include/mod_python.h
@@ -103,7 +103,7 @@
 #define NOTSILENT 1

 /* hopefully this will go away */
-#define MAX_LOCKS 32
+#define MAX_LOCKS 4

/* python 2.3 no longer defines LONG_LONG, it defines PY_LONG_LONG */
#ifndef LONG_LONG

--------------

I think we should take the 32 number to something like 8 and add a comment that for a high-performance configuration you'd need to increase this number.

Grisha


I've added --with-max-locks option to configure and set the default to 8. Shall I commit the changes?

Jim

Reply via email to