On Fri, Oct 21, 2005 at 10:10:51PM +0100, Colm MacCarthaigh wrote:
> support/logresolve doesn't support IPv6 addresses, which is a pain,
> because while logresolve is not a brilliant log resolver, it's useful
> for putting at the end of brief command lines, grepping things and so
> on.
>
> Anyway;
>
> http://people.apache.org/~colm/logresolve.c
>
> is an APR version, it's also a lot shorter than the current version.
Looks good; some nits:
- odd style in places, some "if("/"while(" without enough whitespace
and declarations with too much whitespace:
apr_file_t * etc;
- apr_hash_* can use APR_HASH_KEY_STRING rather than strlen(key)
- odd casts to/from (const void *) in hash handling which shouldn't
be necessary?
joe
