Gregory (Grisha) Trubetskoy wrote:
On Tue, 29 Nov 2005, Jim Gallacher wrote:
I still think the correct place to create the index dictionary is in
the __init__ phase. Using the dictionary-on-demand idea only improves
performance on the second access to a form field. For the first access
you are still iterating through the whole list for each field name.
I am still not convinced we need an index. I'd like to see some concrete
proof that we're not engaging in "overoptimization" here - is this
really a bottleneck for anyone?
Well, I need to get some real work done today, but I will do some
benchmarking at some point. It's not like there's a big rush to complete
3.3.0 this week. I do like that Mike's code simplifies a number of the
the FS methods. It just looks more elegant.
If we're concerned (and I'm not at this point) that FieldStorage is too
slow, we should just rewrite the whole thing in C :-)
A worthy goal. Perhaps we should re-write all of mod_python in C.... Any
takers? No? Maybe not then. :)
Jim
