On Thu, Dec 15, 2005 at 11:59:14PM -0800, Justin Erenkrantz wrote: > On Thu, Dec 15, 2005 at 11:55:30PM +0100, Ruediger Pluem wrote: > > While reading the code of ap_http_chunk_filter I wondered myself if there > > is bug > > in the handling of flush buckets in ap_http_chunk_filter. Maybe I just do > > not > > understand correctly the way ap_http_chunk_filter works. > > I think you're absolutely correct. Nice catch! > > Your patch looks right. Please commit to trunk. And, a +1 to merge back > to 2.0 and 2.2. The fact that no one's caught this before is just weird.
There are occassional reports from Subversion users of the neon "Chunked delimiter was invalid" error, which is exactly the error which would be triggered by a bug like this. Often such reports are blamed on network corruption or the Darwin poll() bug, but I'm not sure they have all been diagnosed like that. > I bet we might be able to write up a mod_bucketeer test for this (not that > I have any clue how to write it; but I'd imagine we could). -- justin Done as t/http11/chunked2.t joe
