On Dec 31, 2005, at 3:45 PM, [EMAIL PROTECTED] wrote:
Author: brianp Date: Sat Dec 31 15:45:11 2005 New Revision: 360461 URL: http://svn.apache.org/viewcvs?rev=360461&view=rev Log: Refactoring of ap_read_request() to store partial request state in the request rec. The point of this is to allow asynchronous MPMs do do nonblocking reads of requests. (Backported from the async-read-dev branch)
Umm, this needs more eyes. It doesn't seem to me to be doing anything useful. It just adds a set of unused input buffer fields to the wrong memory structure, resulting in what should be a minor (not major) MMN bump, and then rearranges a critical-path function into several subroutines. The nonblocking yield should happen inside ap_rgetline (or its replacement), not in the calling routine. The thread has nothing to do until that call is finished or it times out. In any case, this code should be independent of the MPM and no MPM is going to do something useful with a partial HTTP request. I say -1 to adding the input buffer variables to the request_rec. Those variables can be local to the input loop. I don't see any point in placing this on trunk until it can do something useful. ....Roy
