I mean, of course, having status be simple flags +d+s
for example, rather than the whole word. The code looks
to be designed with that in mind.

On Feb 1, 2006, at 8:57 AM, Jim Jagielski wrote:


Why the breaks? Certainly we still want to continue the
for loop even if we see a valid setting. For example,
to set a worker in DISABLED and STOPPED mode.

On Jan 31, 2006, at 4:32 PM, Ruediger Pluem wrote:

Index: modules/proxy/mod_proxy.c
===================================================================
--- modules/proxy/mod_proxy.c   (Revision 371134)
+++ modules/proxy/mod_proxy.c   (Arbeitskopie)
@@ -200,18 +200,21 @@
                     worker->status |= PROXY_WORKER_DISABLED;
                 else
                     worker->status &= ~PROXY_WORKER_DISABLED;
+                break;
             }
             else if (*v == 'S' || *v == 's') {
                 if (mode)
                     worker->status |= PROXY_WORKER_STOPPED;
                 else
                     worker->status &= ~PROXY_WORKER_STOPPED;
+                break;
             }
             else if (*v == 'E' || *v == 'e') {
                 if (mode)
                     worker->status |= PROXY_WORKER_IN_ERROR;
                 else
                     worker->status &= ~PROXY_WORKER_IN_ERROR;
+                break;
             }
             else {
                 return "Unknow status parameter option";


Reply via email to