On Wednesday 15 March 2006 21:34, Jeff Trawick wrote: [ disclaimer: I haven't looked at the code in question, but I've dealt with the issue I mention in mod_dbd, and gone through the logic at greater length for the book ]
> util_ldap_create_config() creates the per-server config for util_ldap. > That saves a config-time pool in the per-server config. > > The child init hook really needs to talk the server_recs and create > the mutex there, right? That makes sense. There's a somewhat similar issue in mod_dbd in 2.2.0, using pchild where it should be using its own pool and a mutex. This is fixed in trunk (thanks mostly to Chris Darroch) and is currently languishing at the top of PATCHES PROPOSED TO BACKPORT FROM TRUNK. Perhaps people could look at that whilst on the subject of pools usage? > Also, is the pool growth of the config-time pool reasonable? Is it growing per-request? If so it definitely wants some kind of workaround, such as a private pool with garbage-cleaning. > If it is reasonable to grow some pool over time during the request > processing, shouldn't it be an ldap-unique pool? Agreed. -- Nick Kew
