=?iso-8859-1?Q?Pl=FCm=2C_R=FCdiger=2C_VIS?= wrote: > > > > > -----Urspr=FCngliche Nachricht----- > > Von: Jim Jagielski=20 > >=20 > > > > + file_cache_errorcleanup(dobj, r); > > > + return APR_EGENERAL; > > > + } > >=20 > > Why don't we return rv ? > > Because we also return APR_EGENERAL in the cases below. I think the = > behaviour > should be consistent. So if we think that returning rv is better we = > should > also do this below. I am fine with either decision. >
That seem to be the case when we have a general error. In other places where we have a valid 'rv', we tend to return that. Look at file_cache_recall_mydata() for example... In the above, I think the return status may be useful, so we shouldn't mask it, imo. -- =========================================================================== Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ "If you can dodge a wrench, you can dodge a ball."
