Brian J. France wrote:

The patched block of code is only called when f->ctx is NULL and hasn't been setup yet by mod_deflate. I would assume when a sub request would get added the ctx for its ap_filter_t struct would be NULL and f->r->main would be the top request so the deflate filter would be removed.

Ding ding ding :)  Ok thank you for pointing that out... once we have a filter
context we won't muck this up.

It seems this should be a conditional add-filter, never a  conditional remove
filter event.  add-filter on the top level request, noop on nested requests.

Not sure I have the expertise to comment on that.

No need, your patch is fine :)  Thanks for clarifications.

Reply via email to