On Mon, May 15, 2006 at 06:56:35PM -0000, [EMAIL PROTECTED] wrote:
> Author: sctemme
> Date: Mon May 15 11:56:34 2006
> New Revision: 406716
>
> URL: http://svn.apache.org/viewcvs?rev=406716&view=rev
> Log:
> Propose backport of ServerName directive enhancement
Hey, let's put new features in the stable branch!
1) CHANGES entries should be first and foremost readable by your average
server admin; I'd suggest two entries, one which is admin-readable, one
which is aimed at the module developer:
*) Add optional 'scheme://' prefix to ServerName directive,
allowing correct determination of the canonical server URL
for use behind a proxy or offload device handling SSL; fixing
redirect generation in those cases.
*) Added server_name field to server_rec for above. Minor MMN bump.
The fact that you tested the change is certainly not something that
needs documenting in CHANGES. There's also a PR for this bug I think
somewhere... PR 33398, which should be referenced (and closed, since
it's unlikely to be fixed for 1.3).
2) this introduced a compiler warning so the fix for that needs
backporting too at least (r405010)
3) for a known-length pstrndup use pstrmemdup not pstrndup when you know
there is no NUL in the length being dup'ed; this is wrong twice in the
core.c changes
4) again in core.c:
cmd->server->server_scheme = (const char *)scheme;
that looks like an unnecessary cast.
joe
