> -----Ursprüngliche Nachricht----- > Von: Brian Akins > Niklas Edmundsson wrote: > > > > This patch takes advantage of the possibility to do the > size-check of > > the file to be cached early. > > obj->vobj = dobj = apr_pcalloc(r->pool, sizeof(*dobj)); > > > Shouldn't this be in mod_cache so that all providers do not have to > duplicate this logic?
Possibly, but right now there is no mod_cache directive regarding the object sizes. All object size directives are provider specific. Thus this check has to happen in the provider code as mod_cache does not know anything about object size limitations. And yes, I think that having them provider specfic is a good thing, because if you use multiple providers in parallel you might want to have provider specific max and min values for the objects. Regards Rüdiger
