On Thursday 27 July 2006 18:36, Sander Temme wrote: > Have you reviewed the patch? This is a small modification that takes > unsupported code out of the compile path when building with -DDEBUG.
I'm not happy with applying *any* local patch to a third-party package. With PCRE we have a quite a track record of trouble, as witness for example the length of the Cc; list (and the comments!) at http://issues.apache.org/bugzilla/show_bug.cgi?id=27550 > I have this in all my working copies. It does not break the PCRE > interface. In the following message to [EMAIL PROTECTED], PCRE author Philip > Hazel all but admits forgetting to ifdef these calls out in this file > (which gets #included from pcre.c only if DEBUG is #defined): > > http://mail-archives.apache.org/mod_mbox/httpd-dev/200504.mbox/% > [EMAIL PROTECTED] It seems to me he (tentatively?) agrees there's a problem. That's not the same as accepting your patch: it just means ensuring the underlying problem gets fixed. > This just makes it easier for folks to build debug builds and help us > out: People building for debug are presumably starting from source. Where's the problem with configure --with-pcre? for them? > The real solution of course, is to upgrade to the current release of > PCRE, version 6.7. However, we should probably not do that on the > stable branches. At the risk of being a bore, the real solution is to unbundle pcre! Less confusing for people who compile from source, and perfectly within the capabilities of any package management system worth its salt. > Please reconsider your bale. I'm in two minds about that. There is the workaround of configure --with-pcre but where does that leave packages? PR#27550 names two modules that needed to work around the bundled PCRE: mod_php and mod_caml. That implies two workarounds for the same problem. What if the PHP and CAML folks (or AN Other with the same problem) were to adopt mutually incompatible solutions? AFAICT the only mitigating circumstance is that this patch is not the underlying problem, so I'm complaining at a symptom rather than the cause. But it feels like "when in a hole, dig deeper". -- Nick Kew
