On 07/28/2006 06:34 PM, [EMAIL PROTECTED] wrote:

> Added: 
> httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/health_checker_util.c
> URL: 
> http://svn.apache.org/viewvc/httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/health_checker_util.c?rev=426604&view=auto
> ==============================================================================
> --- 
> httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/health_checker_util.c
>  (added)
> +++ 
> httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/health_checker_util.c
>  Fri Jul 28 09:33:58 2006

> +/* read the entry stored in the shared area and build the corresponding 
> worker structure */
> +static apr_status_t get_entry(int id, proxy_worker **worker, char 
> **balancer_name, apr_pool_t *pool)
> +{
> +    struct proxy_worker_conf *workerconf = NULL;
> +    apr_status_t rv;
> +
> +    if (myscore == NULL)
> +        return APR_ENOSHMAVAIL;
> +    rv = checkstorage->ap_slotmem_mem(myscore, id, (void *) &workerconf);

What should be done if we never have added an worker to this id and thus all 
fields
in **workerconf are zero? Wouldn't it make sense to set *worker to NULL and 
return
an error (something like NOT_INIT)?

Regards

RĂ¼diger

Reply via email to