On 09/06/2006 07:58 AM, wrote: > Author: trawick > Date: Tue Sep 5 22:58:14 2006 > New Revision: 440624 > > URL: http://svn.apache.org/viewvc?view=rev&rev=440624 > Log: > propose a concrete patch for backporting ap_get_server_version() > changes to 2.2.x without breaking existing modules >
> + > + * full server version information in the error log at startup as well as > server > + status reports, regardless of ServerTokens > + http://people.apache.org/~trawick/banner-2.2.x-rev1.txt A few comments: --- server/core.c (revision 440616) +++ server/core.c (working copy) + +/* ap_get_server_version() is deprecated. ap_get_server_banner() + * provides the same semantics. + */ +AP_DECLARE(const char *) ap_get_server_version() { + return ap_get_server_banner(); +} + Some style nits. I would prefer the following lines: /* * ap_get_server_version() is deprecated. ap_get_server_banner() * provides the same semantics. */ AP_DECLARE(const char *) ap_get_server_version(void) { return ap_get_server_banner(); } --- include/ap_mmn.h (revision 440616) +++ include/ap_mmn.h (working copy) @@ -111,6 +111,8 @@ * proxy_server (minor) * 20051115.2 (2.2.2) added inreslist member to proxy_conn_rec (minor) * 20051115.3 (2.2.3) Added server_scheme member to server_rec (minor) + * 20051115.4 (2.2.4) Added ap_get_server_banner() and + * ap_get_server_description() (minor) */ You made a comment about the minor bump, but you forgot to do it :-). Regards Rüdiger
