Niklas Edmundsson wrote:
This patch implements copying a file in the background so the client initiating the caching can get the file delivered by read-while-caching instead of having to wait for the file to finish.
Something that Joe Orton raised, and that I've been looking into in more detail.
The copy_body function currently only supports file buckets, which specifically excludes buckets generated by say mod_proxy, or mod_cgi. From my testing, for these non file buckets, the response is downloaded and cached fully, then the client gets fed data. Initially I understood this as an optimisation specific to files, assuming that file buckets were the only buckets that could potentially exceed available RAM, but the case where non file buckets are present is currently unhandled.
In theory, the copy body should be able to read from any brigade, rather than just a file brigade, in such a way that it doesn't try and load 4.7GB into RAM at once for file buckets.
I am jetlagged right now and can't think straight any more today, will carry on looking at this tomorrow :)
Regards, Graham --
smime.p7s
Description: S/MIME Cryptographic Signature
