On 11/16/2006 02:25 PM, Plüm wrote: > >>-----Ursprüngliche Nachricht----- >>Von: Nick Kew >>Gesendet: Donnerstag, 16. November 2006 02:36 >> >> >>On Wed, 15 Nov 2006 21:33:07 +0100 >>Ruediger Pluem <[EMAIL PROTECTED]> wrote: >> >> >>>Because of your question I had to rewalk the code path and I think >>>I found two other bugs with my code. I fixed them on trunk: >>> >>>http://svn.apache.org/viewvc?view=rev&revision=475403 >> >>Hang on. It's worse than that. Or else I'm suffering >>"shouldn't be working in the wee hours" syndrome. >> >>When you first set up the validation buffer, you copy available >>data into it, and set validation_buffer_length. Now the memcpy >>in this section of code is overwriting validation_buffer, >>when it should be appending to it. Then you increment the >>buffer_length, and decrement avail_in by the number of bytes >>appended. At that point, if avail_in is nonzero we might want >>to log a warning of extra junk. > > > Argh. You are right. Good catch. I have currently no svn access but
Ok. This is what I committed to address the issues found today and yesterday: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_deflate.c?r1=426799&r2=475922 As I know that diffs of diffs become unreadable r426799 + above: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_deflate.c?r1=426795&r2=475922 Provided that you see nothing else I would try to get a minute on the weekend to adjust things in the STATUS file. > > >>Edge-cases can be notoriously hard to test. I wonder if there's >>a compression/zlib test suite we could use? > > > Regarding the compressed content I simply used files that I compressed with > gzip and stripped of the gz extension. I guess the hard case here is to split Plus SetOutPutFilter INFLATE Header set Content-Encoding gzip early in the configuration as the inflate filter only works on content with content-encoding set to gzip. Regards Rüdiger
