Justin Erenkrantz wrote: > On 12/30/06, Ruediger Pluem <[EMAIL PROTECTED]> wrote: >> Digging somewhat deeper it turns out that adding APR_FINFO_NAME to the >> list of wanted >> information causes this apr_stat to return always APR_INCOMPLETE on >> Unix platforms in >> the case that the call to the native stat / lstat does not fail. This >> raises the >> following questions: >> >> 1. Do we need to add APR_FINFO_NAME to this apr_stat call? I think we >> do not need it >> on Unix platforms but I am not sure if this is true for other >> platforms. > > resolve_symlink seems to preserve it. *shrug* > >> 2. If we need it can we simply ignore an APR_INCOMPLETE return code on >> all platforms >> and only bail out if ((rv != APR_INCOMPLETE) && (rv != APR_SUCCESS)) > > +1. -- justin
+/-1 - Accepting APR_INCOMPLETE was an excellent choice. But your patch falls one step short. It's necessary to inspect fstat.valid before we use specific fields.
