On May 17, 2007, at 2:53 PM, Justin Erenkrantz wrote:
BTW, I'm not a fan of us inventing Expires headers in this section of
code - I'd think it'd be far cleaner to off-load Expires response
header generation to mod_expires and leave the cache out of it
entirely - inventing Expires values deep inside of mod_cache seems
unclean. mod_cache, IMO, should just respect what it is told and not
change how things appear to downstream folks. (mod_expires is more
than capable of inserting in the Expires header if the admin wants
it.)
I agree -- caches are not allowed to invent header fields like Expires.
They can only do so by explicit override in the configuration
(mod_expires).
Setting Expires here is wrong. Changing max-age would be even worse.
Age is the only thing the cache should be setting.
Does my position make sense? I'm of the opinion that we should go one
of two ways:
- mod_cache shouldn't touch the response - so it stops setting Expires
or anything like that which affects cachability
+1
- mod_cache always tweaks the response - so my CC: max-age fix needs
to mimic what we do for Expires.
-1
....Roy
