Jim Jagielski wrote:

On Jul 17, 2007, at 10:31 AM, [EMAIL PROTECTED] wrote:
+ if (*(workers->s->route) && strcmp(workers->s->route, route) == 0) {

Is that right? I'm guessing the 1st check was to make sure
that workers->s->route wasn't NULL (and therefore the strcmp
didn't dump), but instead you're checking that the 1st
character isn't '\0'... or was that the intent?



It is checking for '\0' see modules/proxy/mod_proxy.h (typedef struct { ... } proxy_worker_stat.

So *(workers->s->route) && could be removed from the test. Note the same code exists in find_route_worker() it could be fixed there too.

Cheers

Jean-Frederic

Reply via email to