On 08/03/2007 05:42 PM, [EMAIL PROTECTED] wrote: > Author: niq > Date: Fri Aug 3 08:42:30 2007 > New Revision: 562507 > > URL: http://svn.apache.org/viewvc?view=rev&rev=562507 > Log: > Generalise the content encoding detection and protocol: > so it aslo works in inflate out filter, as suggested by rpluem. > > NOTE: this fails with some generators (cgi, asis) due to a deeper bug: > content-encoding is set later than mod_deflate sees it. This has always > been the case, and could use a separate fix if anyone wants inflate_out > other than in a proxy situation. And it's not mod_deflate's problem.
So your idea is to address PR 42993 separately? > > Modified: > httpd/httpd/trunk/modules/filters/mod_deflate.c > > Modified: httpd/httpd/trunk/modules/filters/mod_deflate.c > URL: > http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_deflate.c?view=diff&rev=562507&r1=562506&r2=562507 > ============================================================================== > @@ -995,6 +982,10 @@ > return ap_pass_brigade(f->next, bb); > } > > + /* these are unlikely to be set anyway, but ... */ > + apr_table_unset(r->headers_out, "Content-Length"); > + apr_table_unset(r->headers_out, "Content-MD5"); > + apr_table_unset(r->headers_out, "Content-Range"); I agree with Joe's comment a while a ago that we simply should remove ourselves if we see a Content-Range header (in both cases input and output filter). I think we can only deliver a result in this case that is not expected by the client. It might make even sense that in the output filter case we return a 416 if the request headers contain a Range header. Regards Rüdiger
