On 10/28/2007 02:32 AM, André Malo wrote: > * Nick Kew wrote: > >> Our subrequest API currently handles only local subrequests, >> so for example mod_include doesn't support >> <!--#include virtual="http://example.com/example.txt"-->. >> I've worked around this in the past with some ugly hacks. > > How ugly are they? I'd rather accept them than... > >> Looking at the code, it's actually very simple to build >> in support for remote URLs into the subrequest mechanism >> using mod_proxy. I've just test-driven a patch comprising >> just six lines of code (attached), and it works. >> >> The patch still needs attention to escaping, but before >> I deal with that, can I ask for votes on the concept? >> Is there any reason not to add this feature? > > It opens a big can of worms. See the neverending story of faulty php > scripts. > -0 from here. I think this is a point where mod_include should stop.
Possibly mod_include should stop there, but "remote" subrequest are valuable for other modules (e.g. mod_ssl and OCSP). So +1 to add this to the API, -0 for enabling it for mod_include. > > Besides that, shouldn't your patch trigger a gateway request instead of > regular proxy? Thats also my feeling. PROXYREQ_REVERSE seems more appropriate. Regards Rüdiger
