On Nov 14, 2007 4:18 PM, Ruediger Pluem <[EMAIL PROTECTED]> wrote: > > + b = APR_BRIGADE_FIRST(ctx->bb); > > + status = apr_bucket_read(b, data, len, APR_BLOCK_READ); > > Isn't it dangerous that we do not copy *data here? > Doesn't this data get lost when we delete the bucket in the while loop below?
Yup. Should be addressed in r595070. > How do we set *found if the status is not EAGAIN? Doh. r595077. > > + apr_brigade_pflatten(ctx->bb, data, len, ctx->pool); > > Shouldn't this be ctx->tmp_bb? > Shouldn't we call apr_brigade_cleanup(ctx->tmp_bb) here? *don paper bag* r595079. Thanks. -- justin
