Hi, On Monday 03 December 2007, Stefan Fritsch wrote: > But I found two locations where the creation of a new brigade could > be avoided: > > - In buffer_output()/ap_old_write_filter(), it is possible to keep > the brigade around and reuse it after the next flush. > > - In ap_http_chunk_filter(), a new brigade is created for every > flush bucket. But it is not really necessary if the flush bucket is > the last bucket in the brigade. > > I don't know yet whether the saving is significant in practice. But > it saves two brigades on every combination of > ap_rwrite()/ap_rflush() and mod_php uses ap_r*() quite a lot. > > A patch is attached. It's against 2.2.6 but applies to trunk.
I now got a report that this patch helped in one case where the system used to run out of memory pretty quickly [1]. Could someone please review the patch? Maybe it's not too late for 2.2.7 yet? Cheers, Stefan [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=421557
