Michael Clark wrote:
I'm getting a segfault here in mod_dav from trunk (after a make clean)
running litmus using extras/httpd-dav.conf whereas it was working for me
last night. Not sure if this a work-in-progress. No time to file a bug
right now as i'm off for the weekend.
/* Set the ETag header required by dav_meets_conditions() */
-> if ((err = (*resource->hooks->set_headers)(r, resource)) != NULL) {
return dav_push_error(r->pool, err->status, 0,
"Unable to set up HTTP headers.",
err);
}
I think the set_headers hook for mod_dav_fs is a NULL pointer unless
DEBUG_GET_HANDLER in dav/fs/repos.c is non-zero, which it isn't by
default. Using the getetag hook should work to make sure the ETag
is in place before calling ap_meets_conditions(), though, if I read the
code correctly. The originally proposed patch in #38034 does this, IIRC.
Like you, I'm off for the weekend, plus taking my first real holiday
break in a few years. If no one else deals with this before Wednesday,
though, I'll see what I can do. Sorry in advance for the delay.
Chris.
--
GPG Key ID: 366A375B
GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B
