On Apr 17, 2008, at 10:25 AM, Jim Jagielski wrote:


On Apr 17, 2008, at 10:04 AM, Plüm, Rüdiger, VF-Group wrote:

But sure this could be also fixed in the appropriate canon_handler
hooks of mod_proxy_http and mod_proxy_ajp.


That's what I'm wondering... Treating this "special" inside
of mod_proxy itself, when it's really a protocol issue (and
what is "right" for that protocol) just seems a safer way.
Or, at least, helps to maintain that illusion of abstraction :)


Something like:

Index: mod_proxy_http.c
===================================================================
--- mod_proxy_http.c    (revision 649076)
+++ mod_proxy_http.c    (working copy)
@@ -72,7 +72,9 @@
      * has already been decoded.  True proxy requests have r->uri
      * == r->unparsed_uri, and no others have that property.
      */
-    if (r->uri == r->unparsed_uri) {
+    if ((r->uri == r->unparsed_uri) ||
+        ((r->proxyreq == PROXYREQ_REVERSE) &&
+          apr_table_get(r->notes, "proxy-nocanon"))) {
         search = strchr(url, '?');
         if (search != NULL)
             *(search++) = '\0';

ajp and fcgi similarly... :)

Reply via email to