On Apr 19, 2008, at 2:49 PM, Ruediger Pluem wrote:
On 04/19/2008 06:22 PM, Jim Jagielski wrote:
On Apr 19, 2008, at 6:11 AM, Ruediger Pluem wrote:
If you have no further objections I would commit it.
Hmmmm.... from what I can see, the conditional for '(r->uri == r-
>unparsed_uri)'
doesn't seem to be required anymore in our local code, so it
seems safe enough to remove. When that's done, the code reduces
to your patch...
I am somewhat concerned about possible regressions with that
reduction however (hence my version which retained it - unless I
am confident that regression won't occur, I tend not to remove
legacy codepaths :) )... But I see no real reason not to commit
So do I. But I am confident that there is no regression :-).
Well, I'm like 99% sure. It's just that some modules directly
create a proxy subreq and may expect this logic flow... if they
do, then it is arguably their problem :)
I just committed (r649840).
+1
