Ruediger Pluem wrote:
On 06/20/2008 11:12 PM, [EMAIL PROTECTED] wrote:
Author: tdonovan
Date: Fri Jun 20 14:12:34 2008
New Revision: 670061
URL: http://svn.apache.org/viewvc?rev=670061&view=rev
Log:
After r649840, mod_proxy_http will no longer append a query string
from r->args if "no-canon".
...
I think this will break in the case that we have a forward proxy. So my
proposal would be:
Leave as is (or better was)
> - if (rulestatus == ACTION_NOESCAPE) {
> - apr_table_setn(r->notes, "proxy-nocanon", "1");
> - }
> -
...
or even better to
> - if (r->args != NULL &&
> - ((r->proxyreq == PROXYREQ_PROXY) || (rulestatus ==
ACTION_NOESCAPE))) {
> - /* see proxy_http:proxy_http_canon() */
> - r->filename = apr_pstrcat(r->pool, r->filename,
> - "?", r->args, NULL);
Understood. Changed it to:
((r->proxyreq == PROXYREQ_PROXY) || (rulestatus == ACTION_NOESCAPE))
Regards,
-tom-
