On Oct 22, 2008, at 11:05 AM, Manik Taneja wrote:
With regards to the patch, it seems that the changes in event.c have no effect. We have anyway seen the leak with both worker and event mpm. The changes in scoreboard.c just ensure that memory pointed to by new_sbh is not lost everytime ap_create_sb_handle is called.
But this implies that any code which calls ap_create_sb_handle() needs to ensure that *new_sbh isn't NULL, and, iirc, most just define them (eg: ap_sb_handle_t *sbh;) so the value is garbage. Thus, this seems to also imply a change to the API (since current code will break with the ap_create_sb_handle() change.
I have tested this fix and the memory consumption has dropped drastically, however I still do observe a slow leak at times. I haven't got the opportunity to spend a whole lot of time testing the fix. Its on my plate however, and I'll send out my findings to the group sometime next week.
Agreed that the mod_proxy_http.c patch looks reasonable at 1st blush, but need to look into all possible interaction with the change to a shorter-lived pool.
