Ruediger Pluem wrote:

On 10/29/2008 05:41 PM, [EMAIL PROTECTED] wrote:
Author: niq
Date: Wed Oct 29 09:41:10 2008
New Revision: 708935

URL: http://svn.apache.org/viewvc?rev=708935&view=rev
Log:
Introduce modules/system, and mod_unixd.c

mod_unixd.c is only os/unix/unixd.c, turned into a module.
(or more accurately, an ugly hack).  Work in progress, and the
old unixd will have to go once the module build stuff is in place.
....

Just a remark. In all current MPM's ap_run_child_init runs with the root
privileges already dropped. In the simple MPM this is now different in
general (we are running with root priviledges here). But as mod_unixd
registers an APR_HOOK_FIRST hook this will not make a difference for
most modules as their child_init hooks are still run with the
privileges already dropped.

As said just a remark and no comment as I haven't made up my mind
so far if this is good or bad.

Yup, I want to make a new hook, 'drop_privileges', and move most of mod_unixd to using it -- and then restore the existing behavior to child_init.

-Paul

Reply via email to