Re: svn commit: r721965 - in /httpd/httpd/trunk/modules/filters: config.m4 mod_ratelimit.c mod_ratelimit.h

[Paul Querna]

Ruediger Pluem wrote:

On 12/01/2008 06:12 AM, [EMAIL PROTECTED] wrote:

Author: pquerna
Date: Sun Nov 30 21:12:22 2008
New Revision: 721965

URL: http://svn.apache.org/viewvc?rev=721965&view=rev
Log:

Add a new module, mod_ratelimit, originally written at Joost, which can rate limit the outgoing bandwidth to a client.

Added:
    httpd/httpd/trunk/modules/filters/mod_ratelimit.c   (with props)
    httpd/httpd/trunk/modules/filters/mod_ratelimit.h   (with props)
Modified:
    httpd/httpd/trunk/modules/filters/config.m4

I guess you missed a change entry here.

Added in r723682.

....

+            while (!APR_BRIGADE_EMPTY(bb)) {
+                apr_bucket *stop_point;
+                apr_off_t len = 0;
+
+                if (f->c->aborted) {
+                    apr_brigade_cleanup(bb);
+                    ctx->state = RATE_ERROR;

Shouldn't we do a break or continue here?

Fixed in r723681.
...

Regards

Rüdiger

Thanks Again,

Paul